Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwords can't be reset if e-mail isn't setup #2831

Closed
jader9920 opened this issue Apr 7, 2024 · 8 comments · Fixed by #2932 or #2933
Closed

Passwords can't be reset if e-mail isn't setup #2831

jader9920 opened this issue Apr 7, 2024 · 8 comments · Fixed by #2932 or #2933
Labels
enhancement New feature or request

Comments

@jader9920
Copy link

What happened?

Forgot admin password and when completing the forgot password flow and error message states "Email is not enabled on this server. You cannot perform this action"

What did you expect?

I expected to be able to pull the password reset link from the system log.

Kavita Version Number - Don't see your version number listed? Then your install is out of date. Please update and see if your issue still persists.

0.7.14 - Stable

What operating system is Kavita being hosted from?

Docker (Dockerhub Container)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

None

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Firefox, Microsoft Edge

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

No response

Relevant log output

No response

Additional Notes

No response

@jader9920 jader9920 added the needs-triage Needs to be triaged by a developer and assigned a release label Apr 7, 2024
@majora2007 majora2007 added this to To do in v0.8 - PDF & Comic Love via automation Apr 7, 2024
@majora2007
Copy link
Member

Okay I thought this was a bug, but I actually made a decision to not enable this flow. I'll need to think of an alternative way to implement in case the admin forgot their stuff and don't use an email with their instance (not that email is used in any way other than within Kavita).

Something like an alternative api call (but there can be security concerns with that).

@majora2007 majora2007 added discussion In active discussion and removed needs-triage Needs to be triaged by a developer and assigned a release labels Apr 7, 2024
@Eboraci
Copy link

Eboraci commented May 1, 2024

Any update on this subject? Or ideas of how could we "workaround" this particular problem, just for now? I've been unable to login on my admin account for some time due to the same circunstances, i would love to resume from my last read chapter ):
Sorry that i cannot be of any more help on the scope of this situation.

Thanks.

@majora2007
Copy link
Member

@Eboraci did you try the flow on v0.8.1? I believe I tweaked the logic to drop a URL in logs but reject the UI flow

@majora2007 majora2007 added enhancement New feature or request and removed discussion In active discussion labels May 2, 2024
@majora2007
Copy link
Member

Okay I confirmed I did not update this yet. This is due to the complexity. I will take this up for v0.8.2 as it's pretty common for admin's to forget their own password (use a password manager).

@majora2007 majora2007 moved this from To do to Done, Not Pushed in v0.8 - PDF & Comic Love May 2, 2024
@Eboraci
Copy link

Eboraci commented May 2, 2024

Sorry for the delayed response, forgot to reply on your comment, but yes, there no such thing in the logs folder.

About the password manager, i use on every single non-local application, i did not used in this one specifically since its local and, since it never asked for my password for more than one time (when i was using it daily for +- 30 days), i eventually forgot that it was ever needed.

Thanks for understanding the situation and for the consideration of rolling this to v0.8.2.

@therobbiedavis
Copy link
Collaborator

One enhancement that could be done as like an "all else fails" is if in the db the password is set to something like "reset" manually, then when Kavita is started it could check and overwrite those with random passwords and dump the username and new password in the logs.

v0.8 - PDF & Comic Love automation moved this from Done, Not Pushed to Done May 4, 2024
@Eboraci
Copy link

Eboraci commented May 4, 2024

Thanks, keep up the good work!

@majora2007
Copy link
Member

Please note that this will release with v0.8.2. If you want to validate it yourself or provide feedback, you can on the nightly docker (don't use your main instance as there are db changes that make rolling back problematic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants