Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Multiple Notes Entries On Every Cheatsheet Level #32

Open
Robert-M-Muench opened this issue Jan 8, 2020 · 5 comments
Open

Allow Multiple Notes Entries On Every Cheatsheet Level #32

Robert-M-Muench opened this issue Jan 8, 2020 · 5 comments

Comments

@Robert-M-Muench
Copy link

1..N top-level notes
1..N category notes
1..N entry notes

@holyjak
Copy link

holyjak commented Sep 20, 2021

I see I can have multiple td_notes on an entry but just a single notes (a later one overrides the former)

@Kapeli
Copy link
Owner

Kapeli commented Sep 22, 2021

How would multiple notes be handled? Where would they appear? What would the HTML output to?

@holyjak
Copy link

holyjak commented Sep 22, 2021

After havingread these current docs:

td_notes (under entry) - just like notes, but multiple ones are added in a separate column (as opposed to a separate row)

I assumed that notes adds a separate row inside the entry. If I understand it correctly, now an Entry is implemented as a <tr> inside a table, with the first and only TD holding the <div class="name"> and <div class="notes">. One could argue that additional notes could be simply appended to the content inside that div.

It could be also argued that this is unnecessary complexity and work for you and if I want to have mutliple notes, I can concatenate the content manually and put it inside a single note. If you decide for this way, it would be nice to add an error checking and fail with a clear message ("only a single notes allowed) instead of silently overriding any previous notes on the same entry. Also clarifying the docs would be nice:

td_notes (under entry) - just like notes but can be repeated multiple times, each becoming a separate column

@Kapeli
Copy link
Owner

Kapeli commented Sep 23, 2021

I see. I have no issues with adding support for multiple notes, apart from time. Pull requests welcome.

td_notes (under entry) - just like notes but can be repeated multiple times, each becoming a separate column

I've made this change. Thank you!

@holyjak
Copy link

holyjak commented Sep 24, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants