Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBC Datasource property should allow to select or create a bean #967

Open
lhein opened this issue Mar 21, 2024 · 3 comments
Open

JDBC Datasource property should allow to select or create a bean #967

lhein opened this issue Mar 21, 2024 · 3 comments

Comments

@lhein
Copy link
Contributor

lhein commented Mar 21, 2024

When configuring a JDBC component you have to specify a mandatory Data Source Name. This can be the name of an existing bean (don't use the # for a bean reference, this doesn't work in this case...just use the plain name) or alternatively you can put there one of 2 constants:

  • dataSource
  • default

If you specify one of these 2 constants then the JDBC component will try to lookup a datasource bean from the registry. (See the tooltip in the screenshot below)

Image

Source Example:

Image

@lordrip
Copy link
Member

lordrip commented Mar 21, 2024

Ok, if I'm understanding correctly, in this case, the dataSource field should allow to create or select existing beans but without having a # prefix.

@lhein
Copy link
Contributor Author

lhein commented Mar 21, 2024

It can be also a predefined constant...see above description

@lordrip
Copy link
Member

lordrip commented Mar 21, 2024

yup, I saw that part as well. Judging by the list of custom features this field might require, I think it would be better to provide something custom for this case. It could also automatically add predefined beans for known databases.

@lhein lhein modified the milestone: 2.0.0 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants