Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog filter text field should enable all 3 top toggles and display results from all 3 former tabs #1040

Closed
lhein opened this issue Apr 26, 2024 · 4 comments · Fixed by #1051
Assignees
Labels
catalog Catalog-related issues ui/ux This issue is about improving the UI / UX
Milestone

Comments

@lhein
Copy link
Contributor

lhein commented Apr 26, 2024

when using the filter text box we should always display results from all 3 categories.

@lhein lhein added this to the 2.0.0 milestone Apr 26, 2024
@lhein lhein added catalog Catalog-related issues ui/ux This issue is about improving the UI / UX labels Apr 26, 2024
@igarashitm igarashitm self-assigned this Apr 26, 2024
@igarashitm
Copy link
Contributor

igarashitm commented Apr 26, 2024

Here is the one with a minimal change - I don't like having components and kamelets laying flat. How about showing them group by group with title for each? For example Showing 3 components have 3 and Showing 3 kamelets have another 3, then simply stack them vertically. Don't show Showing 0 processors as it has zero.
Screenshot from 2024-04-26 13-45-45

BTW group titles are singular like component and kamelet... I'd simply show group-name + s for now to do the above.

Cc @lordrip

@igarashitm
Copy link
Contributor

Also wondering what's the expected behavior in combination with #1039, type the search word, then click the Type. For example with the mongo search result above, when user clicks kamelet, do we remove mongo kamelets from the result? what if then user add b to the search, so it gets mongod? show the kamelets again? otherwise the behavior conflicts.

@igarashitm
Copy link
Contributor

Generally speaking, without knowing the background of this issue, it's not a good practice to make one axis (word search) influence the other axis (category toggle). Those decisions should be independent.

@igarashitm
Copy link
Contributor

Also, same question could apply for category badges - do we want to do the same thing (i.e. disable category badge filtering) whenever search word is not empty or not?

igarashitm added a commit to igarashitm/kaoto-next that referenced this issue Apr 30, 2024
igarashitm added a commit to igarashitm/kaoto-next that referenced this issue Apr 30, 2024
…iple types at the same time

2nd shot - instead of collapsible grouped section, added a header tag of "Component", "Processor" or "Kamelet" to indicate the type, so it could be distinguished at a first glance

Fixes: KaotoIO#1039
Fixes: KaotoIO#1040
igarashitm added a commit to igarashitm/kaoto-next that referenced this issue Apr 30, 2024
…iple types at the same time

2nd shot - instead of collapsible grouped section, added a header tag of "Component", "Processor" or "Kamelet" to indicate the type, so it could be distinguished at a first glance

Fixes: KaotoIO#1039
Fixes: KaotoIO#1040
igarashitm added a commit to igarashitm/kaoto-next that referenced this issue Apr 30, 2024
…iple types at the same time

2nd shot - instead of collapsible grouped section, added a header tag of "Component", "Processor" or "Kamelet" to indicate the type, so it could be distinguished at a first glance

Fixes: KaotoIO#1039
Fixes: KaotoIO#1040
igarashitm added a commit to igarashitm/kaoto-next that referenced this issue Apr 30, 2024
…iple types at the same time

2nd shot - instead of collapsible grouped section, added a header tag of "Component", "Processor" or "Kamelet" to indicate the type, so it could be distinguished at a first glance

Fixes: KaotoIO#1039
Fixes: KaotoIO#1040
lordrip pushed a commit that referenced this issue May 2, 2024
…iple types at the same time

2nd shot - instead of collapsible grouped section, added a header tag of "Component", "Processor" or "Kamelet" to indicate the type, so it could be distinguished at a first glance

Fixes: #1039
Fixes: #1040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
catalog Catalog-related issues ui/ux This issue is about improving the UI / UX
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants