Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom DataFormats #1017

Open
lordrip opened this issue Apr 16, 2024 · 5 comments
Open

Support custom DataFormats #1017

lordrip opened this issue Apr 16, 2024 · 5 comments
Labels
canvas/config-form Configuration form related issues catalog Catalog-related issues enhancement New feature or request ui/ux This issue is about improving the UI / UX

Comments

@lordrip
Copy link
Member

lordrip commented Apr 16, 2024

Please describe the feature that you want to propose

At the moment of writing, only DataFormats provided through the Camel Catalog are supported.

The goal for this ticket would be to add option to be able to select a custom DataFormat or to provide a reference to a DataFormat bean. Ideally, this should render a Bean configuration field that allows the user to pick an existing bean or to create one.

image

Related read: https://camel.apache.org/manual/dataformat-dsl.html

@lordrip lordrip added enhancement New feature or request catalog Catalog-related issues canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX labels Apr 16, 2024
@igarashitm
Copy link
Contributor

We already have custom dataformat in the form. The ref is supposed to be a BeanReferenceField, but it seems not ATM - it could be a bug.
Screenshot from 2024-04-16 12-22-25

@igarashitm
Copy link
Contributor

@lhein
Copy link
Contributor

lhein commented Apr 16, 2024

yep, we should make it cross connect to the beans tab / enhancing the text field as a typeahead dropdown with a button for create

@lhein
Copy link
Contributor

lhein commented Apr 16, 2024

we should try to filter for beans that match the required type for that field if defined but also we should try to offer an option ("Show More") to select from an unfiltered list.

@igarashitm
Copy link
Contributor

igarashitm commented Apr 16, 2024

The tricky part for filtering beans is that it requires Java class hierarchy knowledge, for example we don't know org.postgresql.ds.PGConnectionPoolDataSource implements javax.sql.DataSource

We need either

  • Retrieve class hierarchy data from vscode (rather from vscode Java extension?)
  • Have a dictionary for the well known implementation classes such as SQL DataSource, JMS ConnectionFactory, etc
    • This is at some level related to the bean template - Provide Beans templates #508
    • Unfortunately this won't work for user created classes such as custom DataFormat, custom AggregationStrategy, etc. It would need to register manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canvas/config-form Configuration form related issues catalog Catalog-related issues enhancement New feature or request ui/ux This issue is about improving the UI / UX
Projects
Status: Backlog
Development

No branches or pull requests

3 participants