Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow creating contests with duplicate contests_code #109

Open
Vishal1541 opened this issue Apr 11, 2019 · 7 comments
Open

Disallow creating contests with duplicate contests_code #109

Vishal1541 opened this issue Apr 11, 2019 · 7 comments
Labels
admin For admins panel bug Something isn't working

Comments

@Vishal1541
Copy link
Member

Implement a check for the duplication of contest code before creating a new contest.
localhost/admin/new-contest

image

Here two contests with same code FRST has been created which should not be.
image

@Vishal1541 Vishal1541 added bug Something isn't working admin For admins panel labels Apr 11, 2019
@shrirangpdeshmukh
Copy link
Contributor

Can I work on this issue?

@shrirangpdeshmukh
Copy link
Contributor

Can I take this up now?

@InfiniteVerma
Copy link

InfiniteVerma commented Dec 20, 2020

This seems resolved already. In ./controls/admin.js line no 152, flag_contest variable is being used to check whether a contest with the same code already exists or not.

@pranshukharkwal
Copy link
Collaborator

@InfiniteVerma @shrirangpdeshmukh
As I can see, when you create a contest with an already existing code, it does not create a new contest, but also doesn't show any error. So maybe we could add an alert here which you ask the user to choose a different contest code as this one is already taken.

@InfiniteVerma
Copy link

Alright.

@shrirangpdeshmukh
Copy link
Contributor

I have created a PR addressing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin For admins panel bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants
@Vishal1541 @pranshukharkwal @InfiniteVerma @shrirangpdeshmukh and others