Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse requests on line-basis #488

Open
Kaliumhexacyanoferrat opened this issue Apr 30, 2024 · 0 comments
Open

Parse requests on line-basis #488

Kaliumhexacyanoferrat opened this issue Apr 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Kaliumhexacyanoferrat
Copy link
Owner

As HTTP is a line based protocol, I expected the parser to parse it line by line, which simplifies the parsing process and should yield better performance.

Example

Pseudo code.

var headerLine = ReadLine();

while ((var header = ReadLine()) != null) { }

This would eliminate a lot of branches in the scanner and make the parser more resilient in total.

Acceptance criteria

  • HTTP requests are parsed line by line
  • It has been verified that there are no new allocations introduced
  • Acceptance tests still pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant