Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tank thermals by type #317

Open
Capkirk123 opened this issue Jun 17, 2023 · 2 comments
Open

Tank thermals by type #317

Capkirk123 opened this issue Jun 17, 2023 · 2 comments

Comments

@Capkirk123
Copy link
Member

I'm not entirely sure which mode this would belong under, but as discussed on Discord, being able to set tank thermals by tank config would allow more realistic thermals on steel vs aluminum tanks, as well as allowing some meaningful variation in the shielded tank type and the potential for suborbital-rated tank types.

@Starwaster
Copy link
Contributor

Starwaster commented Jun 22, 2023

If I understand the question correctly, this is already a thing.

look at the configs for LOX tanks vs LH2 tanks. LOX are steel. LH2 are aluminum. That is reflected in conductivity and thickness. If those are set correctly then conduction will be calculated correctly, taking into consideration the necessary abstractions due to this being a game and not a supercomputer simulation.

Caveat: I designed and implemented the system in use post KSP 1.xx but am no longer involved with Real Fuels and can’t guarantee that what I wrote above is current. Indeed there have been a number of changes made (in the past couple of years) which I would never have made that affect tank thermals in a bad way. I created an issue over a year ago addressing that but it has not been answered.

@Capkirk123
Copy link
Member Author

That is not what I intended, although it would be good to do also. I would like to be able to change the part max temperature based on what tank config is selected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants