Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open FIXMEs #84

Open
2xB opened this issue Nov 20, 2023 · 1 comment
Open

Open FIXMEs #84

2xB opened this issue Nov 20, 2023 · 1 comment

Comments

@2xB
Copy link
Member

2xB commented Nov 20, 2023 •
edited

There are multiple open FIXMEs in the code. One significant one is the new MagfieldCoils implementation: It still shows compiler warnings that may hint to relevant issues. This is hidden here: https://github.com/KATRIN-Experiment/Kassiopeia/blob/6d703553c96155730edf2d791e9e5aa60ebfdb7a/KEMField/Source/ExternalFields/MagfieldCoils/CMakeLists.txt#L42C1-L42C109

We should fix the underlying issues and remove that line.
@richeldichel
Copy link
Contributor

I have actually been working on this and will provide a pull request this week.

@richeldichel richeldichel mentioned this issue Nov 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@2xB @richeldichel