Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo doesn't work #6

Open
extf33 opened this issue Dec 6, 2022 · 4 comments
Open

Undo doesn't work #6

extf33 opened this issue Dec 6, 2022 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@extf33
Copy link

extf33 commented Dec 6, 2022

Undo does not work after variable rename.

@xmhwws
Copy link

xmhwws commented Dec 6, 2022

Sometimes openai is wrong and needs to undo its operation to make ida change back to the previous state.

@JusticeRage JusticeRage added the help wanted Extra attention is needed label Dec 6, 2022
@JusticeRage
Copy link
Owner

JusticeRage commented Dec 6, 2022

That would be nice to have, but I have no idea how to do it. Quoting from this StackOverflow answer by an Hex Rays employee:

Only interactive user actions can be undone via the UI or keyboard shortcut.

If the variable names are not satisfactory, the best I can offer for now is to press Ctrl + Alt + R to generate new names.

@jpenalbae
Copy link
Contributor

Save an history of the renames and rename them back to their original names? Maybe keep track just for the last function...

@JusticeRage
Copy link
Owner

The thing is, storing the modifications isn't that much of an issue... What is complex is receiving the user intent of cancelling a modification. The plugin can't hijack the whole CTRL+Z hotkey as this would interfere with IDA as a whole, but having a separate one just for Gepetto (or a menu item like Gepetto > Cancel rename) would feel inconvenient.

I'm sure there is a way to do this properly with IDA, unfortunately my relationships with HexRays at the moment are not great so asking support is not an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants