Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of FrequencySimulationResult.ω from RowVector in to just Vector? #24

Closed
arturgower opened this issue Apr 28, 2019 · 1 comment

Comments

@arturgower
Copy link
Member

As of Julia 1.0, RowVector is no longer a thing. See this issue.

Instead there is a type Transpose, Adjoint, or just Array{2}. All in all, I think there is plenty of room for confusion now, and the intuitive idea of having a "lying down" vector is lost. So I suggest just using Vector for the type FrequencySimulationResult.ω.

@jondea
Copy link
Member

jondea commented Apr 29, 2019

I agree, also thanks for working on moving to Julia 1.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants