Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proportionmap should accept any iterator #842

Open
cossio opened this issue Dec 3, 2022 · 0 comments · May be fixed by #855
Open

proportionmap should accept any iterator #842

cossio opened this issue Dec 3, 2022 · 0 comments · May be fixed by #855
Labels
good-first-pr

Comments

@cossio
Copy link

cossio commented Dec 3, 2022 

julia> x = [1, 2, 3]
3-element Array{Int64,1}:
 1
 2
 3

julia> proportionmap(skipmissing(x))
ERROR: MethodError: no method matching proportionmap(::Base.SkipMissing{Vector{Int64}})
Closest candidates are:
  proportionmap(::AbstractArray) at ~/.julia/packages/StatsBase/XgjIN/src/counts.jl:455
  proportionmap(::AbstractArray, ::AbstractWeights) at ~/.julia/packages/StatsBase/XgjIN/src/counts.jl:456
Stacktrace:
 [1] top-level scope
   @ REPL[4]:1

Ref. #581 for countmap.
@ArunS-tack ArunS-tack linked a pull request Mar 4, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proportionmap accepts iterators ArunS-tack/StatsBase.jl
2 participants
@ararslan @cossio