Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other factorizations: parametrization or new names? #198

Open
timholy opened this issue Nov 20, 2023 · 1 comment
Open

Other factorizations: parametrization or new names? #198

timholy opened this issue Nov 20, 2023 · 1 comment

Comments

@timholy
Copy link
Contributor

timholy commented Nov 20, 2023

Based on mateuszbaran/CovarianceEstimation.jl#90 we're likely to want something like PDMat that supports different factorizations. Two factorizations are currently under discussion:

Both of these can be efficiently checked for positive (semi) definiteness and would seem to fit here. There seem to be multiple instantiations, though: should the existing PDMat be renamed PDCholesky? Or should we add a F<:Factorization{T} parameter? Either is workable, I'm opening this largely to ask for guidance about your preferences.

CC @mateuszbaran

@devmotion
Copy link
Member

We are about to unify PDMat and PDSparseMat in #188. This will already introduce a F<:Factorization type parameter, so extending PDMats to other factorizations will be much simpler after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants