Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadening input types for ApproximatePermutationTest #314

Open
marcpabst opened this issue Jan 28, 2024 · 0 comments
Open

Broadening input types for ApproximatePermutationTest #314

marcpabst opened this issue Jan 28, 2024 · 0 comments

Comments

@marcpabst
Copy link

marcpabst commented Jan 28, 2024

I was poking around the ApproximatePermutationTest function and this is the current signature:

function ApproximatePermutationTest(rng::AbstractRNG, x::AbstractVector{R}, y::AbstractVector{S},
                                    f::Function, n::Int) where {R<:Real,S<:Real}

I'm curious about the decision to restrict the input types for x and y to AbstractVector{<:Real}. It seems to me that the function might be more flexible if it accepts a broader range of input types, provided that the function f returns a subtype of Real.

Would expanding the accepted input types for x and y introduce any significant issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant