Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reintroduce SpecialFuncs #335

Open
mzaffalon opened this issue Feb 25, 2020 · 3 comments
Open

reintroduce SpecialFuncs #335

mzaffalon opened this issue Feb 25, 2020 · 3 comments

Comments

@mzaffalon
Copy link
Contributor

mzaffalon commented Feb 25, 2020

SpecialFuncs were removed in v1.0.0. Is there any plan to reintroduce them? What would it take? I would volunteer, if somebody can give guidance.

@jverzani
Copy link
Collaborator

Hmm, I can't recall why. I'd guess it is because we can access the sympy functions directly through x.func() style now. But if you wanted the julia counterparts, you could just define them directly, or use introspection the way importexport.jl is generated from import_sympy. It would be great it you did so,.

@mzaffalon
Copy link
Contributor Author

I had a look at the file and it looks fairly straightforward. I will make the PR.
I suggest we keep SpecialFuncs in a submodule, unless there are objections.

@jverzani
Copy link
Collaborator

Okay, great. Thanks for tackling this. Just to be clear, the importexport.jl file is generated so don't make changes there. If you have to hand code things, just do so in the submodule. If they can be generated through introspection, then modify import_sympy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants