Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error #1

Open
bflynn882 opened this issue May 8, 2023 · 14 comments
Open

Error #1

bflynn882 opened this issue May 8, 2023 · 14 comments

Comments

@bflynn882
Copy link

Hello, I'm using Windows Subsystem for Linux and got an error after uploading my musicxml file. Attached are two screenshots of the error. Any help would be appreciated, looking forward to using this. Thanks!

Screenshot1
Screenshot2

Bryan

@NeroBlackstone
Copy link
Member

Hi, thanks for your feedback, please upload your .musicxml file in this issue.
Or send your musicxml to gf7600gs@gmail.com if you don't want to public sheet music.

@NeroBlackstone
Copy link
Member

I have downloaded this musicxml, maybe the problem is "repeat notation", I never consider this situation.

@bflynn882
Copy link
Author

bflynn882 commented May 9, 2023 via email

@NeroBlackstone
Copy link
Member

Thanks for your feedback. Please send your piano sheet to my email. I will check it when I have time.

@NeroBlackstone
Copy link
Member

What is your computer hardware configuration?Program should finished in few minutes.

@bflynn882
Copy link
Author

bflynn882 commented May 9, 2023 via email

@NeroBlackstone
Copy link
Member

You can try it, I can't guarantee it will work correctly, I tested this package only on Linux.

@bflynn882
Copy link
Author

So I got it to work with a random piece that I downloaded. It was River Flows in You. I'll attach the song in an email I'll send you right now because it won't let me upload a musicxml file on github. But it still won't work with the song Champagne Problems without any repeats. I'm still getting the bounds error. I'd appreciate it if you could help whenever you get a chance. Thanks.

@bflynn882
Copy link
Author

bflynn882 commented May 11, 2023 via email

@NeroBlackstone
Copy link
Member

NeroBlackstone commented May 11, 2023

I'll attach the song in an email I'll send you right now because it won't let me upload a musicxml file on github.

You could compress musicxml to zip file and upload.

@NeroBlackstone
Copy link
Member

I have confirmed a bug from music21, some bounds errors can't be fixed by myself.

@bflynn882
Copy link
Author

Ok, thanks a lot.

@michael-nhat
Copy link

There seem tobe many bugs, I export from midi file download from musescore org to musicxml (by musescore4, on archlinux), and files meet diffirent errors

file 2
error:

 12.681950 seconds (230.87 M allocations: 8.952 GiB, 31.95% gc time, 160.44% compilation time)
left hand start:
ERROR: notes too short
Stacktrace:
 [1] split_notes(notes_by_position::Vector{MIDI.Notes{MIDI.Note}}, hand::PianoFingering.Hand)
   @ PianoFingering ~/git-repo/PianoFingering.jl/src/split.jl:7
 [2] splited_range(notes_by_position::Vector{MIDI.Notes{MIDI.Note}}, hand::PianoFingering.Hand)
   @ PianoFingering ~/git-repo/PianoFingering.jl/src/split.jl:79
 [3] run_splite(notes::Vector{MIDI.Notes{MIDI.Note}}, hand::PianoFingering.Hand)
   @ PianoFingering ~/git-repo/PianoFingering.jl/src/process.jl:3
 [4] fingering(file_name::String)
   @ PianoFingering ~/git-repo/PianoFingering.jl/src/process.jl:130
 [5] top-level scope
   @ REPL[13]:1

file 1
error:

  7.029996 seconds (100.48 M allocations: 4.043 GiB, 26.04% gc time, 301.03% compilation time)
ERROR: number of fingering and note not equal.
Stacktrace:
 [1] annotation(part::PyCall.PyObject, fgs::Vector{DataStructures.SortedDict{MIDI.Note, PianoFingering.Finger}})
   @ PianoFingering ~/git-repo/PianoFingering.jl/src/process.jl:85
 [2] fingering(file_name::String)
   @ PianoFingering ~/git-repo/PianoFingering.jl/src/process.jl:137
 [3] top-level scope
   @ REPL[10]:1

Could you create wiki or tutorial, documentation for it to fix stuff better?

@NeroBlackstone
Copy link
Member

Thank you for the feedback, I must confess PianoFingering.jl is still in the early stage. Midi is not a support input, because for performance record midi, we don't know whether the notes belong to the left hand or the right hand.
My plan is to train a neural network to separate the left hand and right hand notes, then add fingering for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants