use buffer in BatchView #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 88.46% 88.57% +0.11%
==========================================
Files 13 15 +2
Lines 598 604 +6
==========================================
+ Hits 529 535 +6
Misses 69 69
|
ToucheSir
reviewed
May 21, 2023
Comment on lines
+142
to
+149
| function getobs!(buffer, A::BatchView{TElem, TData, Val{nothing}}, i) where {TElem, TData} | ||
| obsindices = _batchindexes(A, i) | ||
| return _getbatch!(buffer, A, obsindices) | ||
| end | ||
|
|
||
| function _getbatch!(buffer, A::BatchView{TElem, TData, Val{nothing}}, obsindices) where {TElem, TData} | ||
| return getobs!(buffer, A.data, obsindices) | ||
| end |
There was a problem hiding this comment.
Suggested change
| function getobs!(buffer, A::BatchView{TElem, TData, Val{nothing}}, i) where {TElem, TData} | |
| obsindices = _batchindexes(A, i) | |
| return _getbatch!(buffer, A, obsindices) | |
| end | |
| function _getbatch!(buffer, A::BatchView{TElem, TData, Val{nothing}}, obsindices) where {TElem, TData} | |
| return getobs!(buffer, A.data, obsindices) | |
| end | |
| function getobs!(buffer, A::BatchView{<:Any, <:Any, Val{nothing}}, i) | |
| obsindices = _batchindexes(A, i) | |
| return _getbatch!(buffer, A, obsindices) | |
| end | |
| function _getbatch!(buffer, A::BatchView{<:Any, <:Any, Val{nothing}}, obsindices) | |
| return getobs!(buffer, A.data, obsindices) | |
| end |
I think we can avoid overspecializing here
Comment on lines
+147
to
+149
| function _getbatch!(buffer, A::BatchView{TElem, TData, Val{nothing}}, obsindices) where {TElem, TData} | ||
| return getobs!(buffer, A.data, obsindices) | ||
| end |
There was a problem hiding this comment.
I would've assumed this also works for collate=true|false, because unlike getobs/_getbatch the caller has already figured out the return type by passing in buffer. Not sure I understand the interface or API contract that well though, so please correct me if not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #156
This covers only
BatchView(...; collate=nothing), I'm not sure howcollate=trueandcollate=falseshould interact with the buffer so I won't address that here.