Codecov Report

Merging #145 (fecc37c) into main (ff2fcc1) will increase coverage by 0.32%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   88.28%   88.60%   +0.32%     
==========================================
  Files          15       13       -2     
  Lines         589      588       -1     
==========================================
+ Hits          520      521       +1     
+ Misses         69       67       -2     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Before, treats 0 like "less than 0", perhaps we can call that a bug?

yes, doesn't deserve a major version bump

well actually previous batchsize=0 behavior is useful, disables batching and makes the dataloader equivalent to eachobs, something that cannot be obtained with batchsize=1.
Maybe we can set batchsize=nothing for maximum batch size?

equivalent to eachobs, something that cannot be obtained with batchsize=1

Isn't this batchsize=-1? That's what the docs seem to say:

julia> DataLoader(ones(2,3); batchsize=1) |> first
2×1 Matrix{Float64}:
 1.0
 1.0

julia> DataLoader(ones(2,3); batchsize=-1) |> first
2-element Vector{Float64}:
 1.0
 1.0

julia> eachobs(ones(2,3)) |> first
2-element Vector{Float64}:
 1.0
 1.0

Perhaps ideally, batchsize=0 would make more sense for the "individual obs without batch dim" command, and batchsize=-1 for "wrap around to largest possible batch". Both are special cases. But this way around would clearly break documented behaviour.

My first idea in #144 was to use batchsize=Inf for "largest possible". It's a little weird to allow only one Float64 value.

Are there other good tokens? Using a function like batchsize=all seems clear to read but pretty unusual. Base uses dims=: internally in many places for "all the dimensions", but not quite like this; seems more like sum(rand(2,3); dims=(1,2))::Matrix than like sum(rand(2,3); dims=:)::Number.