Train test and validation for graph datasets. #168
Conversation
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 33.01% 33.30% +0.28%
==========================================
Files 41 41
Lines 2084 2066 -18
==========================================
Hits 688 688
+ Misses 1396 1378 -18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Can you edit the OP and describe the changes in this PR?
additionally what? |
|
|
||
| An abstract dataset type for graph learning tasks. | ||
| """ | ||
| abstract type GraphDataset <: AbstractDataset end |
There was a problem hiding this comment.
better rename this as
| abstract type GraphDataset <: AbstractDataset end | |
| abstract type AbstractGraphDataset <: AbstractDataset end |
especially if we go with #169
There was a problem hiding this comment.
Also, it is better to file this change as a separate PR. Generally a PR should target a single issue or a single feature addition
|
Let's split the fix to #167 to a separate PR |
| @@ -19,9 +19,9 @@ end | |||
|
|
|||
| function Base.show(io::IO, ::MIME"text/plain", d::D) where D <: AbstractDataset | |||
| recur_io = IOContext(io, :compact => false) | |||
|
|
|||
There was a problem hiding this comment.
it would be good to avoid polluting PRs with this formatting changes, there should be some option in your editor to avoid doing this
|
Too many changes happened in this pr. I will be closing this pr and making separate prayer for each of them. |
Closes #158
Additionally #167