Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport https://reviews.llvm.org/D134641 #21

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Backport https://reviews.llvm.org/D134641 #21

merged 1 commit into from
Oct 17, 2023

Conversation

pxl-th
Copy link

@pxl-th pxl-th commented Oct 17, 2023

This fixes JuliaGPU/AMDGPU.jl#518 which appeared with Navi 3 as a target.

@vchuravy
Copy link
Sponsor Member

Can you fix up the authorship information, and refer the commit you cherry-picked in the commit message?

I normally use git cherry-pick -x

…PRUseVMEMStore

Reviewed By: jpages, arsenm

Differential Revision: https://reviews.llvm.org/D134641

(cherry picked from commit bb24b2c)
@vchuravy
Copy link
Sponsor Member

vchuravy commented Oct 17, 2023

Thanks! And to confirm this is only needed on LLVM 15, and not LLVM 16?

@vchuravy vchuravy merged commit 084cd0f into JuliaLang:julia-release/15.x Oct 17, 2023
@pxl-th
Copy link
Author

pxl-th commented Oct 17, 2023

Yes, this fix is already in LLVM 16.

@pxl-th pxl-th deleted the julia-release/15.x branch October 17, 2023 15:51
@vchuravy
Copy link
Sponsor Member

x-ref JuliaPackaging/Yggdrasil#7551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants