Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support color types #13

Open
mgautam98 opened this issue Jul 1, 2020 · 3 comments
Open

Support color types #13

mgautam98 opened this issue Jul 1, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mgautam98
Copy link

mgautam98 commented Jul 1, 2020 •
edited

Currently, it doesn't accepts Gray type.
The problem seems to lie here

ImageInpainting.jl/src/utils.jl

Line 10 in d776c4b

imfilter_fft(img::AbstractArray{T,N}, kern::AbstractArray{K,N}) where {T<:Real,K<:Real,N} =

The use of imfilter_fft throws error on OffsetArrays
@johnnychen94
Copy link
Member

johnnychen94 commented Jul 1, 2020 •
edited

It looks like an unnecessary restriction, I think ImageFiltering handles OffsetArray pretty well now. Can I count on you for this?

@mgautam98
Copy link
Author

I am working on it.

@johnnychen94 johnnychen94 mentioned this issue Jul 2, 2020
Closed
@juliohm
Copy link
Member

juliohm commented Jul 2, 2020

Thank you guys for working on it, looking forward to see this restriction removed from the codebase. Could you please share the details here as you make the modifications? I have other packages that could also benefit from this improvement.

@juliohm juliohm mentioned this issue Feb 2, 2021
Closed
@juliohm juliohm changed the title inpaint only accepts numerical array as inputs Support color types Feb 2, 2021
@juliohm juliohm added enhancement New feature or request help wanted Extra attention is needed labels Feb 2, 2021
@juliohm juliohm mentioned this issue Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juliohm @johnnychen94 @mgautam98