Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a findall version of mapwindow #224

Open
johnnychen94 opened this issue Sep 2, 2021 · 0 comments · May be fixed by #225
Open

introduce a findall version of mapwindow #224

johnnychen94 opened this issue Sep 2, 2021 · 0 comments · May be fixed by #225

Comments

@johnnychen94
Copy link
Member

Originally posted in #223 (review)

We have mapwindow that applies function f on every local patch of an image, which can be seen as the image version of map. We don't have the window version of findall that applies f to each local patch, and return coordinates such that f(window_of_p) == true.

Why we need this? We can currently do this by returning a dense Bool matrix from mapwindow and then call findall, but this would usually be unnecessary and not as performant as the manually written for-loops. For example, the benchmark in JuliaImages/ImageSegmentation.jl#72 (comment)

@timholy timholy linked a pull request Sep 3, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant