Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FREAK & BRISK Descriptors #7

Open
7 of 10 tasks
mronian opened this issue Aug 9, 2016 · 2 comments
Open
7 of 10 tasks

FREAK & BRISK Descriptors #7

mronian opened this issue Aug 9, 2016 · 2 comments

Comments

@mronian
Copy link
Contributor

mronian commented Aug 9, 2016

FREAK Roadmap

  • Freak Best Pairs
  • Orientation Pairs
  • Mean Intensity
  • Orientation of Patch
  • Sample Pairs for Descriptor
  • Modified Hamming Distance calculator (calculates distance in parts)

BRISK Roadmap

  • Need AGAST corners
  • Orientation (Long & Short Pairs)
  • Sample Pairs
  • Keypoint Maxima
@mronian mronian changed the title FREAK Descriptor FREAK & BRISK Descriptors Aug 9, 2016
@mronian
Copy link
Contributor Author

mronian commented Aug 15, 2016

@timholy Some descriptors like ORB and BRISK (currently working on this with FREAK) also calculate keypoints for description. If someone wants just the keypoints, there should be an option to retrieve those. But if the same keypoints are to be passed on to the create_descriptor function later on, they wont make any sense since we need the orientation as well as the scale of each keypoint. I was thinking of having a Feature type -

type Feature
     keypoint::Keypoint
     orientation::Float64
     scale::Float64
end

and then return an Array{Feature} from the extract_features function. Will such a structure make iteration over keypoints/features slow, since the person will probably just need the keypoints?

@timholy
Copy link
Member

timholy commented Aug 16, 2016

No, it should be fine. Make it an immutable, though; then it will be just 32 bytes per Feature in the array (2_Int+2_Float64=32 bytes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants