Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename AngleAxis to AxisAngle? #218

Open
hyrodium opened this issue Jan 15, 2022 · 0 comments
Open

rename AngleAxis to AxisAngle? #218

hyrodium opened this issue Jan 15, 2022 · 0 comments
Labels

Comments

@hyrodium
Copy link
Collaborator

hyrodium commented Jan 15, 2022

As discussed in #210, it's better to follow the order of SVector.

julia> aa = AngleAxis(2.4, 0, 0, 1) # angle, x, y, z
3×3 AngleAxis{Float64} with indices SOneTo(3)×SOneTo(3)(2.4, 0.0, 0.0, 1.0):
 -0.737394  -0.675463  0.0
  0.675463  -0.737394  0.0
  0.0        0.0       1.0

julia> Rotations.params(aa).z  # this should be 1
0.0

julia> Rotations.params(aa).w  # this should be 2.4
1.0

If we change the order from (theta, axis_x, axis_y, axis_z) to (axis_x, axis_y, axis_z, theta) (or just (x,y,z,angle)), then the name of the type should be changed to AxisAngle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant