Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code clarity of recurrence_matrix #136

Open
Datseris opened this issue May 22, 2022 · 0 comments
Open

Source code clarity of recurrence_matrix #136

Datseris opened this issue May 22, 2022 · 0 comments
Labels
clarity Will increase clarity of source code or high level API good first issue An easy issue, suitable for new contributors.

Comments

@Datseris
Copy link
Member

At the moment the source code of recurrence_matrix, which is where the central computations of a recurrence matrix take place, is full of duplication. There version complexity scales as 2 x 2 x 2 = 8, with a multiplicity of 2 for (recurrences vs cross-recurence), (parallel vs non parallel), (dataset vs vector).

I do not believe that having 8 different methods is necessary. In fact, it may even be that we could do everything with 1 or 2 methods, by defining smaller helper functions.

In any case, a multiplicity of 8 is certainly not necessary and the source code can be simplified to remove duplication and thus make long term maintanance also easier.

@Datseris Datseris added clarity Will increase clarity of source code or high level API good first issue An easy issue, suitable for new contributors. labels May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarity Will increase clarity of source code or high level API good first issue An easy issue, suitable for new contributors.
Projects
None yet
Development

No branches or pull requests

1 participant