Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

counts_and_outcomes for BubbleSortSwaps should also accept state space sets #391

Open
kahaaga opened this issue Jan 16, 2024 · 0 comments
Open

counts_and_outcomes for BubbleSortSwaps should also accept state space sets #391

kahaaga opened this issue Jan 16, 2024 · 0 comments
Labels
enhancement New feature or request that is non-breaking good first issue Good for newcomers

Comments

@kahaaga
Copy link
Member

kahaaga commented Jan 16, 2024 •
edited

Like for SequentialPairDistances, this should just skip the embedding step.

This involves annotating x in the current version of codify(::BubbleSortSwaps, x) such that x is an AbstractVector, and adding an additional method for codify that operates on AbstractStateSpaceSets.

The OutcomeSpace overview table entry should also be updated accordingly.
@kahaaga kahaaga added enhancement New feature or request that is non-breaking good first issue Good for newcomers labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request that is non-breaking good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kahaaga