Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slices of higher-dimensional Counts and Probabilities should yield new Counts and Probabilities #350

Open
kahaaga opened this issue Dec 21, 2023 · 3 comments

Comments

@kahaaga
Copy link
Member

kahaaga commented Dec 21, 2023

Relevant outcomes also must be propagated

@kahaaga
Copy link
Member Author

kahaaga commented Dec 22, 2023

On second thought, this is speculative.

Slicing a Probabilities array means the Probabilities will be re-normalized. In most use cases, that is probably not what a user would want.

The reason I thought of it is that viewing a probabilities array should look nice (outcomes should be displayed in the margins) even when slicing. But I don't immediately see how this can be achieved without breaking the contract that the probabilities must sum to 1.

@Datseris
Copy link
Member

Does this has any use to begin with...? Marginal propabilities are not slices anyways.

@kahaaga
Copy link
Member Author

kahaaga commented Dec 28, 2023

For counts it has meaning to slice. For probabilities less so - it would have to be a new type.

In terms of pretty printing, it does have meaning to slice, because one may want to look at some subset of the data other than the default printed slice. But I don't consider this important enough to postpone 3.0. It can be done at a later stage, perhaps by just creating a view that explicitly lets the user know that they are looking at a subset. If we deem it necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants