Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optim example is not functioning #473

Open
Libbum opened this issue Apr 2, 2021 · 11 comments · May be fixed by #1019
Open

Optim example is not functioning #473

Libbum opened this issue Apr 2, 2021 · 11 comments · May be fixed by #1019
Labels
bug Something isn't working documentation

Comments

@Libbum
Copy link
Member

Libbum commented Apr 2, 2021 •
edited

Docs are not building currently because something in the mulit-objective optimisation section of examples/optim.jl is failing.

The run starts the optimisation but never gets to the point of outputting the first set of data. This has happened to me before with BBO, but I'm not sure of the fix. Odd thing is that it's only recently happened in our example file. It's not a Julia 1.5 v 1.6 issue, it's not a recent BBO version issue (master and the current release have the problem), its not a github runner changed OS versions recently (since it's also failing on my local machine).

I need to do a hunt of recent changes to our internals to see if its our fault. In #467 I'm thinking I could just bake in the result and not run the example for now until the issue is resolved. That'll mean both Optim and Zombies will be on the list of examples we need to take care of manually until this is resolved.
@Libbum Libbum added bug Something isn't working documentation labels Apr 2, 2021
@Datseris Datseris assigned Datseris and unassigned Datseris Apr 3, 2021
@Datseris
Copy link
Member

Datseris commented Apr 3, 2021

Yeah, a quick fix seems the best at the moment...

@kavir1698 you wrote the initial BBO example, do you know anything?

@kavir1698
Copy link
Collaborator

I will check it today.

@kavir1698
Copy link
Collaborator

I just ran the example and it went through without a problem.

@Libbum
Copy link
Member Author

Libbum commented Apr 4, 2021

It's intermittent. More frequently failing than not however. Difficult to pin down.

@Libbum
Copy link
Member Author

Libbum commented Apr 6, 2021

Be advised that #467 altered optim.jl to provide a pre-built solution from an older run. The most recent runnable version is from 7b05f7df. One caveat working against current master is that #450 introduced a more robust naming convention to column names in the dataframes, and as such line 150 should be replaced with return mean(data[!, dataname(mdata[1])), mean(data[!, dataname(mdata[2])).

@Libbum
Copy link
Member Author

Libbum commented Jun 5, 2021

BlackBoxOptim has had some recent development and a new release. May be worthwhile testing this again now.

@Tortar Tortar pinned this issue Mar 26, 2024
@Datseris Datseris unpinned this issue Mar 27, 2024
@Tortar
Copy link
Member

Tortar commented Mar 27, 2024

Why was this closed? I don't think optim.jl is actually working, the example is all commented https://github.com/JuliaDynamics/Agents.jl/blob/main/examples/optim.jl, I pinned it because I think it is an important thing to fix

@Datseris
Copy link
Member

https://juliadynamics.github.io/Agents.jl/stable/examples/optim/ shows that it runs, I am confused, what is the error?

@Tortar Tortar reopened this Mar 27, 2024
@Tortar
Copy link
Member

Tortar commented Mar 27, 2024

The fact is that every output is hard-coded in the example as you can see from the source file

@Datseris
Copy link
Member

oooooooh sorry i only looked at the output in the docs :D Why doesn't it work? have you tried just rynning it? what's the error

@Tortar
Copy link
Member

Tortar commented Mar 27, 2024

I didn't even try because the file starts by including a non-existing file :D But It seems very outdated nonetheless

@Tortar Tortar linked a pull request Apr 28, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix optim example JuliaDynamics/Agents.jl
4 participants
@Libbum @kavir1698 @Datseris @Tortar