Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support L, U and factors properties in Cholesky #640

Open
rofinn opened this issue Jun 28, 2022 · 0 comments
Open

Support L, U and factors properties in Cholesky #640

rofinn opened this issue Jun 28, 2022 · 0 comments

Comments

@rofinn
Copy link
Contributor

rofinn commented Jun 28, 2022 •
edited

In relation to other comments here and here I think we should re-add support for getproperty(::Tangent{<:Cholesky}, ...) with :U or :L along with :factors. This would make release 1.35.3 slightly less breaking.

https://github.com/invenia/Nabla.jl/pull/217/files#diff-a51816a450e57348c1c90d807b0a793092bb7e368d759102888820eb2e0ee025R55
@rofinn rofinn changed the title Support L, U and factors in Cholesky Support L, U and factors properties in Cholesky Jun 28, 2022
This was referenced Jun 29, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rofinn