Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type stability tests in reverse mode #72

Open
gdalle opened this issue Jul 30, 2023 · 3 comments
Open

Fix type stability tests in reverse mode #72

gdalle opened this issue Jul 30, 2023 · 3 comments
Labels
performance Improve performance or stability

Comments

@gdalle
Copy link
Collaborator

gdalle commented Jul 30, 2023

At the moment, the JET tests in reverse mode are breaking due to runtime dispatch. This is presumably happening because Zygote-computed pullbacks introduce type instability.
The solution may be to write conditions with explicit rrules.
@gdalle gdalle mentioned this issue Jul 30, 2023
Closed
@gdalle gdalle added the feature New feature or request label Jul 30, 2023
@gdalle
Copy link
Collaborator Author

gdalle commented Jul 30, 2023 •
edited

Investigation seems tricky because of JuliaDebug/Cthulhu.jl#478?

@gdalle
Copy link
Collaborator Author

gdalle commented Aug 8, 2023

I think this is due to inherent type instabilities in AbstractDifferentiation.jl

@gdalle gdalle added performance Improve performance or stability and removed feature New feature or request labels Aug 8, 2023
@gdalle
Copy link
Collaborator Author

gdalle commented Apr 10, 2024 •
edited

Type stability tests are still failing sometimes, even though I switched to DifferentiationInterface in #135. It's hard to guarantee that the (dense or lazy) jacobian of the partial conditions will be type-stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Improve performance or stability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdalle