Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core missing __MINGW32__ directive in time_render.c & vec.c #65

Open
WallyZambotti opened this issue Nov 4, 2020 · 1 comment
Open

Comments

@WallyZambotti
Copy link

In time_render.c the following line 18-20:

AG_Cond agCondBeginRender;
AG_Cond agCondEndRender;
AG_Mutex agCondRenderLock;

Should be changed for:

#ifdef __MINGW32__
__declspec(dllexport) AG_Cond agCondBeginRender;
__declspec(dllexport) AG_Cond agCondEndRender;
__declspec(dllexport) AG_Mutex agCondRenderLock;
#else
AG_Cond agCondBeginRender;
AG_Cond agCondEndRender;
AG_Mutex agCondRenderLock;
#endif

In vec.c the following lines 35-36:

int
ag_vec_expand_(char **data, int *length, int *capacity, int memsz)

should be replaced with:

int
#ifdef __MINGW32__
__declspec(dllexport) ag_vec_expand_(char **data, int *length, int *capacity, int memsz)
#else
ag_vec_expand_(char **data, int *length, int *capacity, int memsz)
#endif

Without these directives compilation will fail if using libtool under CygWin/Msys64 Mingw64

@JulNadeauCA
Copy link
Owner

Is this still an issue? I can't seem to be able to reproduce the problem with msys2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants