New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ui-textbox__input-wrapper
around ui-textbox__input
and ui-textbox__textarea
#488
Comments
Does LastPass add something to the input (like a class or attribute) you could use to adjust the icon position? I'm hesitant to add this because other browsers (like Edge on Windows) add their own password toggle icon on the input as well. |
I think you've misunderstood me a bit. My intention was not to add the show/hide toggle to every password icon, but to add wrapper which would take over the input's styling (bottom border). That would allow (using some per-implementation CSS trickery) to position an icon over the input. Icon next to the input works well in most cases, but isn't really the best option in the case of password input. Thus, I thought of proposed changes more like a flexible way for sizing the input. The whole container would still be clickable, as it was inside
No, it doesn't, and I think it doesn't do that on purpose (disable detection = maximize security).
I got your point. However, if I am to develop my own show / hide solution, it kinda lies within my own responsibilities to disable the windows/ie ones; with this for example: https://stackoverflow.com/a/19952071/1660757 |
Ah, I see that you mean now. If it's just adding the wrapper you can submit a PR. Then handle the CSS changes locally in your app. |
See PR #490 |
ui-textbox__input-wrapper
would have the border styles. It'd allow border to be wider than actual input.Password field processed by password managers has most commonly right-aligned background image. When I create icon that is forced to be positioned on the input field with negative margin (toggle password icon works much better in rendered on the field instead of next to it), the icons overlap with each other.
See screenshot of the thing hacked together:
Is this something you'll consider accepting PR for?
The text was updated successfully, but these errors were encountered: