Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UiAlert properties #468

Open
EmilMoe opened this issue Sep 28, 2019 · 1 comment
Open

UiAlert properties #468

EmilMoe opened this issue Sep 28, 2019 · 1 comment
Labels
enhancement

Comments

@EmilMoe
Copy link
Contributor

EmilMoe commented Sep 28, 2019 •
edited

I have 2 suggestions to this component:

  1. To make it more consistent with the rest of your UI it should have the "icon" property.

  2. I think Vue works best if boolean properties are false by default, thus prettier and easier to set. The dismissible should therefor be something that it's false. It could be either not-dismissible by default or the prop could be changed to (ie) irremovable or persist.
@JosephusPaye
Copy link
Owner

Hi Emil,

Those suggestions make sense, but they'll probably be breaking changes. Can make the changes in the next major release.

PR welcome.

amal-qb pushed a commit to qburst/Keen-UI that referenced this issue Jun 19, 2023
UiAlert enhancement: Change 'dismissible' to 'persist' (JosephusPaye#468
23cc6b5 
)
@amal-qb amal-qb mentioned this issue Jun 19, 2023
Merged
amal-qb added a commit to qburst/Keen-UI that referenced this issue Jun 19, 2023
@amal-qb
Merge pull request #1 from qburst/JosephusPaye#468--Change-dismissibl…
59e4397 
…e-to-persist

UiAlert enhancement: JosephusPaye#468 Change 'dismissible' to 'persist'
@amal-qb amal-qb mentioned this issue Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EmilMoe @JosephusPaye