Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UISelect: when using multiple & keys props list gets scrolled to top after select #437

Open
plakak opened this issue Feb 19, 2019 · 1 comment · May be fixed by #439
Open

UISelect: when using multiple & keys props list gets scrolled to top after select #437

plakak opened this issue Feb 19, 2019 · 1 comment · May be fixed by #439
Labels
bug

Comments

@plakak
Copy link
Contributor

plakak commented Feb 19, 2019

After selecting an item when using multiple and keys props togheter, scroll always gets back to the top.

Steps:

  1. Open https://codesandbox.io/s/9422p2l53p
  2. Open select and scroll to some bottom item.
  3. Click to mark as selected.
  4. Scroll returns to the top.
@JosephusPaye
Copy link
Owner

JosephusPaye commented Feb 21, 2019 •
edited

Thanks for the report, can confirm.

Need to investigate more, but on cursory look, it seems like the filteredOptions computed property is recomputed when an option is selected, which causes the list's scroll to reset and return to the top.

@plakak plakak linked a pull request Mar 5, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UiSelect: disable scroll to top when using multiple
2 participants
@JosephusPaye @plakak