Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specific domains to call makeArbitraryTransaction for specific contracts #945

Open
kronosapiens opened this issue Apr 22, 2021 · 0 comments
Labels

Comments

@kronosapiens
Copy link
Member

In a future world, we would like specific domains to have control of external contracts (such as a Gnosis Safe, or any type of NFT). This means moving past our current makeArbitraryTransaction functionality, which is only global in scope, and introduce some new conception of specific domains being able to call out to external contracts.

One approach to this would be to maintain a mapping of (address => domain) to represent which domain owns and external address. We would introduce a new function (or extend makeArbitraryTransaction) which takes a target, an action, and a domain proof, and assesses that the caller has the permission in the domain which owns the target before executing the action.

As for which roles we would use, we have a few options:

  • Decide that external addresses, being "resources", are under control of the funding permission.
  • Introduce a new level in the mapping, for (address => permission => domain) to allow for the colony to decide which roles have control.
  • Introduce a new role, the "stewardship" role, specifically for managing external contracts.

Additional open questions are whether only one domain can have control of an address at a given time (address => domain), or whether an address should be under the control of multiple ([address][domain] => true).

@area area changed the title Give domains ownership of external contracts Allow specific domains to call makeArbitraryTransaction for specific contracts Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant