Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityRuler fails two basic tests #14187

Open
1 task done
jfernandrezj opened this issue Feb 28, 2024 · 3 comments
Open
1 task done

EntityRuler fails two basic tests #14187

jfernandrezj opened this issue Feb 28, 2024 · 3 comments
Assignees
Labels

Comments

@jfernandrezj
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues and did not find a match.

Who can help?

@danilojsl @maziyarpanahi

What are you working on?

Matching Keyword Patterns from a list of known keywords

Current Behavior

Both current behavior and desired behavior is documented in the branch with the failing tests:
https://github.com/JohnSnowLabs/spark-nlp/tree/issues/aho-corasick-failing-tests

Expected Behavior

Both current behavior and desired behavior is documented in the branch with the failing tests:
https://github.com/JohnSnowLabs/spark-nlp/tree/issues/aho-corasick-failing-tests

Steps To Reproduce

Just run the added tests in the branch:
https://github.com/JohnSnowLabs/spark-nlp/tree/issues/aho-corasick-failing-tests

Spark NLP version and Apache Spark

Spark 3.4
Spark NLP 5.2.2

Type of Spark Application

No response

Java Version

Java 11

Java Home Directory

No response

Setup and installation

No response

Operating System and Version

No response

Link to your project (if available)

No response

Additional Information

No response

@maziyarpanahi
Copy link
Member

@jfernandrezj do you have a PR/fix for this issue?

@jfernandrezj
Copy link
Contributor Author

A branch containing a potential fix for this issue is in:
https://github.com/JohnSnowLabs/spark-nlp/tree/issues/aho-corasick-failing-tests-fix-for-discussion
Please check it out and I can create a PR once we are ok

@danilojsl
Copy link
Contributor

Hi @jfernandrezj

LGFM I think you can create a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants