Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Xcode 9 #763

Open
tgwaste opened this issue Jan 7, 2018 · 9 comments
Open

Updates for Xcode 9 #763

tgwaste opened this issue Jan 7, 2018 · 9 comments

Comments

@tgwaste
Copy link

tgwaste commented Jan 7, 2018

any plans to?

@justdan0227
Copy link

Anyone?

@iDevelopper
Copy link

Please provide more description for this issue. SW works with Xcode 9.

@justdan0227
Copy link

Works just a bunch of warnings.. didn't know if there was a way to clean those up

@tgwaste
Copy link
Author

tgwaste commented Jan 16, 2018

So far Only warning I can't get rid of is here:

automaticallyAdjustsScrollViewInsets' is deprecated: first deprecated in iOS 11.0 - Use UIScrollView's contentInsetAdjustmentBehavior instead

if ( [controllerView isKindOfClass:[UIScrollView class]] )
{
    BOOL adjust = controller.automaticallyAdjustsScrollViewInsets;
    
    if ( adjust )
    {
        [(id)controllerView setContentInset:UIEdgeInsetsMake(statusBarAdjustment(_contentView), 0, 0, 0)];
    }
}

@justdan0227
Copy link

Maybe I missed something but I'm getting this:
screen shot 2018-01-16 at 5 14 51 pm

@tgwaste
Copy link
Author

tgwaste commented Jan 16, 2018

I added a PR (#765) to fix most of this but there are two warnings that remain that hopefully the author can help with:

screen shot 2018-01-16 at 4 43 44 pm

@justdan0227
Copy link

Is this ever going to be updated or is there a new alternative to doing this in the latest version of xCode?

@iDevelopper
Copy link

This is a version with no warning, you have to fork the repo as I think the project is not maintained anymore.

Archive.zip

You can also have a look to another very similar library:

https://github.com/iDevelopper/PBRevealViewController

@Tulakshana
Copy link

I tried the version shared by @iDevelopper. It works fine. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants