Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve useEffect: include dependencies and introduce additional effect which stops scanner when component unmounts #258

Open
spaudanjo opened this issue Jun 9, 2022 · 0 comments · May be fixed by #259

Comments

@spaudanjo
Copy link

Current behavior

Updating properties (e.g. constraints) currently doesn't make the scanner behaviour adapt/reflect these updates. This is because these properties are not in the dependencies array of the useEffect within hooks.ts.

Proposal

Adding the missing dependencies to the useEffect and introducing an additional useEffect` which exclusively does the scanner stopping when the component unmounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant