Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI not proper on Tablet #48

Open
arish-panjwani opened this issue Mar 16, 2022 · 12 comments
Open

UI not proper on Tablet #48

arish-panjwani opened this issue Mar 16, 2022 · 12 comments
Labels
bug Something isn't working

Comments

@arish-panjwani
Copy link

image

Device Info:
Model Name: Lenovo Tab4 10
Android Version: 8.1.0

I have tried running my application on Tablet and the unselected icons are going outside the tab. Also the selected tab icon is not centred properly. Even the circle slightly appears to be oval and not round.

Can you please provide tablet support?

@Jm-Zion
Copy link
Owner

Jm-Zion commented Mar 16, 2022

Hello 👋

Thank you for the report, i'll check that very soon 👍

@Jm-Zion
Copy link
Owner

Jm-Zion commented Mar 16, 2022

Could you provide sample code to reproduce the issue ?

@arish-panjwani
Copy link
Author

You can use your own sample code and run on any android Tablet.

@alz10
Copy link

alz10 commented Mar 18, 2022

For the unselected icons that are going outside the tab, add higher height in bottomBarContainerStyle

@Jm-Zion Jm-Zion added the bug Something isn't working label Mar 20, 2022
@arish-panjwani
Copy link
Author

Tried increasing the height in bottomBarContainerStyle but the curve for selected tab goes up and it doesn't look good.

@Standin-Alone
Copy link

how do you show the tab bar label? i cant show my tab bar label.

@Jm-Zion
Copy link
Owner

Jm-Zion commented Apr 5, 2022

@Standin-Alone You can show the label using the default option from react-navigation :

tabBarLabel: 'Meh'

@Standin-Alone
Copy link

not working for me

@arish-panjwani
Copy link
Author

arish-panjwani commented Apr 6, 2022

Pass your label in the name prop like the following..

<Tab.Screen
options={{ tabBarIcon: tabBarIcon('wallet') }}
name="Wallet"
component={generateScreen('Wallet')}
/>

You can also refer the usage section on the library's home page

@arish-panjwani
Copy link
Author

@Jm-Zion Any update on this?

@tradebulls
Copy link

tradebulls commented Jun 29, 2022

@Jm-Zion Even I am facing this issue in Tablet. Can you please help me to solve this issue?

@tradebulls
Copy link

@Jm-Zion Did you reproduce it at your end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants