Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Skin id by Skin uuid #171

Open
TheRocketOff opened this issue Oct 21, 2021 · 1 comment · May be fixed by #183
Open

Replace Skin id by Skin uuid #171

TheRocketOff opened this issue Oct 21, 2021 · 1 comment · May be fixed by #183
Labels
bug Something isn't working

Comments

@TheRocketOff
Copy link

Hello,

I noticed a problem in the plugin.

Indeed, the ids are no longer functional.

So I propose to replace the ids by the uuids with this code:

Replace private static final String MINESKIN_API = "https://api.mineskin.org/get/id/"; in MineSkinFetcher by private static final String MINESKIN_API = "https://api.mineskin.org/get/uuid/"

And change the name of the method fecthSkinFromIdAsync to fetchSkinFromUniqueIdAsync
And change int id to UUID uuid
@TheRocketOff TheRocketOff added the bug Something isn't working label Oct 21, 2021
@vytskalt
Copy link

Why not create a PR for this?

@Git-Fal7 Git-Fal7 linked a pull request Jul 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add MineSkin UUID system and depecrate MineSkin legacy id system Git-Fal7/NPCLib
2 participants
@vytskalt @TheRocketOff