Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distant NPCs don't spawn when getting closer with ViaVersion #162

Open
Cosmiiko opened this issue May 22, 2021 · 2 comments
Open

Distant NPCs don't spawn when getting closer with ViaVersion #162

Cosmiiko opened this issue May 22, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Cosmiiko
Copy link

Cosmiiko commented May 22, 2021

Describe the bug
NPCs spawned outside of the players' rendering distance will not appear once the player gets closer to the NPC's location if the server is using ViaVersion.

NPCLib usage option
Shaded Maven dependency for npclib-plugin

Server version
This server is running Paper version git-Paper-1618 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

To Reproduce
With a 1.12.2 server running ViaVersion and a 1.16.5 client:

  1. Spawn an NPC far away from the player, far enough that it doesn't / wouldn't render anyway.
  2. In-game, get closer to the NPC
    The NPC never spawns (and the NPCShowEvent is never triggered).

Calling npc.show(player) manually after the player is close enough makes the NPC appear (although it's interact event doesn't trigger either ??).

Expected behavior
The NPC should spawn normally once in render distance, and it's interact event should work as intended.
It does work as intended when the client is running 1.12.2 too.

@Cosmiiko Cosmiiko added the bug Something isn't working label May 22, 2021
@JitseB
Copy link
Owner

JitseB commented May 22, 2021

This seems to be connected to #124. Something is fundamentally wrong with the spawning mechanism. I want to use the chuck request packets supported from 1.9 and forward, but then I have to drop 1.8 support, which would be a bummer...

I'll keep this in mind. Thanks for opening this issue ticket.

@Cosmiiko
Copy link
Author

It might be related, although in my case the Hologram doesn't spawn either, and isShown(p) returns false (which makes sense so long the NPC is out of render distance)..
Anyway, thanks for taking a look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants