Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with next v0.18+ #164

Open
wold5 opened this issue Mar 19, 2024 · 2 comments
Open

Issues with next v0.18+ #164

wold5 opened this issue Mar 19, 2024 · 2 comments

Comments

@wold5
Copy link
Contributor

wold5 commented Mar 19, 2024

Hi, Abridge works fine with v0.18, but breaks when testing the current next (up to and getzola/zola@4bf67af). Thought I'd give you a heads up.

  1. Translation menus don't substitute dashes properly:
    instead of /nl/software/ its //nlsoftware/
    Changing

    <a href="{{ current_url | replace(from=config.base_url, to=config.base_url ~ "/" ~ lcode) | safe }}{%- if uglyurls %}index.html{%- endif %}">{{ macros::translate(key="language_name", default="language_name", i18n=i18n_menu) }}</a>
    {%- else -%}
    to use to=config.base_url ~ lcode ~ '/') fixes it for next, but breaks 0.18.

  2. The logo gets a double // in next(the config base_url omits the dash, as recommended)
    It's fixable by removing the dash here

    <img src="{{ config.base_url | safe }}/{{ config.extra.logo.file | safe }}"{%- if config.extra.logo.alt %} alt="{{ config.extra.logo.alt | safe }}"{%- endif %}{%- if config.extra.logo.width %} width="{{ config.extra.logo.width | safe }}"{%- endif %}{%- if config.extra.logo.height %} height="{{ config.extra.logo.height | safe }}"{%- endif %} />
    {%- endif -%}

Of the recent commits these two come to mind:
getzola/zola@4bf67af (--base-url)
getzola/zola@73e06bd (get_page/get_section language argument)

@Jieiku
Copy link
Owner

Jieiku commented Mar 19, 2024

excellent, thank you. I wonder if these are intended changes or not, will keep an eye on the zola release. (I have it watched on github)

@wold5
Copy link
Contributor Author

wold5 commented Mar 27, 2024

You're welcome. Will keep building with 0.18 for now.

By chance, having just added a site translation, constructing a section path requires code similar to that linked in (1) 😛 So curious what you come up with. Might even fix it myself 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants