Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive. #193

Open
EnguGH opened this issue May 30, 2023 · 0 comments · May be fixed by #194
Open

[Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive. #193

EnguGH opened this issue May 30, 2023 · 0 comments · May be fixed by #194

Comments

@EnguGH
Copy link

EnguGH commented May 30, 2023

Version: 2.0.5

We have this violation warning in console :

[Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive.```

Because of that line :
https://github.com/Jexordexan/vue-slicksort/blob/b46a191bc6f23a1de1494a96543ffde47b5b200c/src/ContainerMixin.ts#L256

It seems like the problem was fixed in 1.2.0 :
https://github.com/Jexordexan/vue-slicksort/commit/12100f383192b202f5d721b89c5978074037388f

But the fixes doesn't exist on version 2.*
@EnguGH EnguGH linked a pull request May 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Register event listeners in passive mode EnguGH/vue-slicksort
1 participant
@EnguGH