Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow results in malformed change notes being embedded into JAR and published to JetBrains Marketplace. #341

Open
nelsonjchen opened this issue Jan 25, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nelsonjchen
Copy link

Describe the bug:

image

The change-notes value in the plugin that is uploaded to the marketplace is malformed. At a glance, this appears to be a malformed derivative of a converting some formatting for GitHub's format.

run: |
CHANGELOG="$(cat << 'EOM' | sed -e 's/^[[:space:]]*$//g' -e '/./,$!d'
${{ github.event.release.body }}
EOM
)"
CHANGELOG="${CHANGELOG//'%'/'%25'}"
CHANGELOG="${CHANGELOG//$'\n'/'%0A'}"
CHANGELOG="${CHANGELOG//$'\r'/'%0D'}"
echo "changelog=$CHANGELOG" >> $GITHUB_OUTPUT

Steps to reproduce:

  1. Get a draft release created.
  2. Publish the release, kicking off the release workflow.
  3. Check the change notes inside the resulting zip to the JAR and/or Jetbrains Marketplace listing.

Expected behavior:

Change notes is not malformed on any target.

Additional context:

@nelsonjchen
Copy link
Author

Ah, this is trying to pass to the next step! The next step uses the output immediately but does not reverse the encoding.

@nelsonjchen
Copy link
Author

I just base64'd it for now. https://github.com/nelsonjchen/Colorized-Project/blob/fd42526ccd0d99f8527574210ea55df5fb5e35ea/.github/workflows/release.yml#L46

I'll probably update with whatever solution is done for this later.

@YannCebron YannCebron added the bug Something isn't working label Feb 8, 2023
nthykier added a commit to nthykier/IDEA-debpkg that referenced this issue Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants