Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 18 missing reference to liquidity argument #90

Open
Nicolas-Mich3l opened this issue Feb 18, 2024 · 0 comments
Open

Chapter 18 missing reference to liquidity argument #90

Nicolas-Mich3l opened this issue Feb 18, 2024 · 0 comments

Comments

@Nicolas-Mich3l
Copy link

In chapter 18 (generalized swapping), eventually swapMath.computeSwapStep is called with an argument: liquidity. Liquidity is not referenced / defined thus far. A look at the code indicates that liquidity should be an part of SwapState, yet SwapState, which is defined for the first time in this chapter does not have liquidity as a field.
As far as I understand it after looking at the code in the repo it is simply the current total liquidity in the pool. However the chapter does need revisions to clarify this for future readers so they don't need to go looking at the code.

The book has been a joy to follow along with btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant