Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces #18

Open
Jean-Baptiste-Camps opened this issue Oct 25, 2017 · 5 comments
Open

Namespaces #18

Jean-Baptiste-Camps opened this issue Oct 25, 2017 · 5 comments

Comments

@Jean-Baptiste-Camps
Copy link
Owner

Look at and fix namespaces issues.

NB:

Namespaces in Imports field not imported from:
  ‘cluster’ ‘network’ ‘sna’
  All declared Imports should be used.
@Jean-Baptiste-Camps
Copy link
Owner Author

This is a very important aspect, and not at all dealt with in the code. See for instance http://r-pkgs.had.co.nz/namespace.html for more explanations (and the manual for writing R packages).

@Jean-Baptiste-Camps
Copy link
Owner Author

* checking R code for possible problems ... NOTE
Import.TEIApparatus: no visible binding for global variable ‘x’
Import.TEIApparatus: no visible global function definition for
  ‘read.csv’
PCC: no visible global function definition for ‘legend’
PCC.Stemma: no visible global function definition for ‘as.network’
PCC.Stemma: no visible global function definition for ‘gplot’
PCC.Stemma: no visible binding for global variable ‘displaylabels’
PCC.Stemma: no visible global function definition for
  ‘network.vertex.names’
PCC.conflicts: no visible global function definition for ‘na.omit’
PCC.conflicts: no visible global function definition for ‘as.network’
PCC.conflicts: no visible global function definition for ‘gplot’
PCC.conflicts: no visible binding for global variable ‘displaylabels’
PCC.conflicts: no visible global function definition for
  ‘network.vertex.names’
PCC.contam: no visible global function definition for ‘par’
PCC.contam: no visible global function definition for ‘legend’
PCC.equipollent: no visible global function definition for ‘as.network’
PCC.equipollent: no visible global function definition for
  ‘as.matrix.network’
PCC.overconflicting: no visible global function definition for ‘pam’
PCC.overconflicting: no visible global function definition for
  ‘barplot’
PCC.overconflicting: no visible global function definition for ‘axis’
PCC.overconflicting: no visible global function definition for ‘par’
PCC.overconflicting: no visible global function definition for
  ‘as.network’
PCC.overconflicting: no visible global function definition for
  ‘as.matrix.network’
PCC.overconflicting: no visible global function definition for
  ‘network.vertex.names’
PCC.overconflicting: no visible global function definition for
  ‘set.vertex.attribute’
PCC.overconflicting: no visible global function definition for ‘gplot’
PCC.overconflicting: no visible binding for global variable
  ‘displaylabels’
PCC.overconflicting: no visible global function definition for
  ‘get.vertex.attribute’
PCC.reconstructModel: no visible global function definition for
  ‘as.network’
PCC.reconstructModel: no visible global function definition for ‘gplot’
PCC.reconstructModel: no visible binding for global variable
  ‘displaylabels’
PCC.reconstructModel: no visible global function definition for
  ‘network.vertex.names’
VL.pValues: no visible global function definition for ‘fisher.test’
VL.pValues: no visible global function definition for ‘plot’
Undefined global functions or variables:
  as.matrix.network as.network axis barplot displaylabels fisher.test
  get.vertex.attribute gplot legend na.omit network.vertex.names pam
  par plot read.csv set.vertex.attribute x
Consider adding
  importFrom("graphics", "axis", "barplot", "legend", "par", "plot")
  importFrom("stats", "fisher.test", "na.omit")
  importFrom("utils", "read.csv")
to your NAMESPACE file.

@Jean-Baptiste-Camps
Copy link
Owner Author

Il faut résoudre la question des globalVariables (la plupart des autres sont résolues dans ma prochaine PR), notamment car importante pour CRAN, cf. Rdatatable/data.table#850

This was referenced Oct 25, 2017
@Jean-Baptiste-Camps
Copy link
Owner Author

NB: utiliser les préfixes d'espace de nom pour un code plus propre et moins ambigu.

@Jean-Baptiste-Camps
Copy link
Owner Author

Use namespace base:: for base functions as well ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant