Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some embed interfaces returning null instead of optional #1282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some embed interfaces returning null instead of optional #1282

wants to merge 1 commit into from

Conversation

felldo
Copy link
Member

@felldo felldo commented Oct 7, 2023

Checklist

Changelog

Breaking Changes

  • Changed the return type of some embed related methods to return an optional as they can return null. (E.g. EmbedThumbnail#getProxyUrl)

Description

Closes: #1281

Footnotes

  1. At least started a running bot instance with your changes and triggered an event so your changed code gets executed. ↩

@felldo felldo added the 🐛 bug Something isn't working label Oct 7, 2023
@felldo felldo added the 🔨 breaking-change An issue or pull requests that would be a breaking change label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 bug Something isn't working 🔨 breaking-change An issue or pull requests that would be a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Embed* implementation methods returning null instead of optional
1 participant
@felldo