Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Embed* implementation methods returning null instead of optional #1281

Open
felldo opened this issue Oct 4, 2023 · 0 comments · May be fixed by #1282
Open

Fix Embed* implementation methods returning null instead of optional #1281

felldo opened this issue Oct 4, 2023 · 0 comments · May be fixed by #1282
Labels
🐛 bug Something isn't working

Comments

@felldo
Copy link
Member

felldo commented Oct 4, 2023 •
edited

Javacord version

3.8.0

Steps to reproduce

No response

What is expected?

Return an Optional instead of null

What is actually happening?

Null is returned

Any additional comments?

The same happens for the other Embed* classes as well like EmbedThumbnail/EmbedVideo and more...
https://discord.com/developers/docs/resources/channel#embed-object-embed-image-structure
@felldo felldo added the 🐛 bug Something isn't working label Oct 4, 2023
@felldo felldo changed the title Fix EmbedImage methods returning null instead of optional Fix Embed* implementation methods returning null instead of optional Oct 4, 2023
@felldo felldo linked a pull request Oct 7, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some embed interfaces returning null instead of optional felldo/Javacord
1 participant
@felldo