Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Member interface #1148

Open
1 of 4 tasks
felldo opened this issue Oct 13, 2022 · 3 comments · May be fixed by #1095
Open
1 of 4 tasks

Expose Member interface #1148

felldo opened this issue Oct 13, 2022 · 3 comments · May be fixed by #1095
Labels
🔨 breaking-change An issue or pull requests that would be a breaking change high priority An issue or pull request with a high priority ✨ feature request New feature or request

Comments

@felldo
Copy link
Member

felldo commented Oct 13, 2022

What feature are you proposing?

This should serve as the current working state and what still needs to be done in the development of exposing the Member interface.

  • SlashCommandInteractionOption needs to have methods to expose the member option in addition to user option (they are the same command option type but differently resolved)
  • Check for all CompletableFuture<User>, Optional<User> and normal User return types if it needs to be converted to returning a member or additional methods need to be added to get a Member
  • Rework listener names (verify if ServerMember*Listener are appropriate) and structure to match the correct things they dispatch from (Member/User). Currently the structure of OptionalUserEvent does not properly fit for events like UserStartTypingEvent which get a Member object if it's from a Server
  • Decide whether the Member should extend from the User and depending on that, listeners need to be reworked a bit to make them attachable to Members / Users
@felldo felldo added the ✨ feature request New feature or request label Oct 13, 2022
@felldo felldo linked a pull request Oct 13, 2022 that will close this issue
@felldo felldo added high priority An issue or pull request with a high priority 🔨 breaking-change An issue or pull requests that would be a breaking change labels Oct 13, 2022
@felldo felldo linked a pull request Oct 21, 2022 that will close this issue
@RealYusufIsmail
Copy link
Contributor

Will have a look at the slash command option one

@Saladoc
Copy link
Member

Saladoc commented Oct 24, 2022

I think all of those issues are addressed in the linked PR which I did not have time to review yet due to the scope. @KILLEliteMaste can you clarify?

@felldo
Copy link
Member Author

felldo commented Oct 24, 2022

The linked PR is the minimum that is required to expose the Member interface. The development has been moved to the Javacord refactor/expose-member branch. All bullet points above have been added after the PR has been made so they are all still open / left to do. PRs to address these or new issues should be made against the refactor/expose-member Javacord branch

@felldo felldo pinned this issue Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 breaking-change An issue or pull requests that would be a breaking change high priority An issue or pull request with a high priority ✨ feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants