Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins with dependancies still get loaded while the dependancies are missing. #2290

Open
ewanhowell5195 opened this issue Apr 24, 2024 · 2 comments
Projects

Comments

@ewanhowell5195
Copy link
Contributor

ewanhowell5195 commented Apr 24, 2024

If you make a plugin that has dependancies, and those dependancies are not installed, blockbench will still try to load the plugin.

The expected behaviour is that the plugin will not load until all dependancies are met.

If this is intentional behaviour, maybe extend the dependancies system to have optional and required dependancies.

@ewanhowell5195 ewanhowell5195 changed the title Plugins will dependancies still get loaded while the dependancies are missing. Plugins with dependancies still get loaded while the dependancies are missing. Apr 24, 2024
@JannisX11
Copy link
Owner

Yeah this wasn't part of the scope for the initial dependencies system, but it's definitely a good addition.

@ewanhowell5195
Copy link
Contributor Author

i would consider this a bug however:

dependancies are not forced to load after the plugins they depend on

@JannisX11 JannisX11 added this to Suggestions in Overview Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Overview
Suggestions
Development

No branches or pull requests

2 participants